Repository navigation
Identify live reload backend technology on the server and show in browser - #8015
Conversation
c10c129 to
ac26686
Compare
mehdi-vaadin
left a comment
There was a problem hiding this comment.
Reviewed 5 of 8 files at r1, 1 of 4 files at r3.
Reviewable status: 4 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @joheriks and @mehdi-vaadin)
flow-client/src/main/resources/META-INF/resources/frontend/VaadinDevmodeGizmo.js, line 177 at r4 (raw file):
} else {
What if liveReloadBackend is null? Should we try to open a connection anyway?
flow-server/src/main/java/com/vaadin/flow/internal/BrowserLiveReload.java, line 37 at r4 (raw file):
Detect
Trivial: Other methods use third-person verbs.
flow-server/src/main/java/com/vaadin/flow/internal/BrowserLiveReloadImpl.java, line 58 at r4 (raw file):
VaadinService service
Is this needed?
joheriks
left a comment
There was a problem hiding this comment.
Reviewable status: 4 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @joheriks and @mehdi-vaadin)
flow-client/src/main/resources/META-INF/resources/frontend/VaadinDevmodeGizmo.js, line 177 at r4 (raw file):
Previously, mehdi-vaadin (Mehdi Javan) wrote…
} else {What if
liveReloadBackendis null? Should we try to open a connection anyway?
Done. Also disabled live-reload toggle when null.
flow-server/src/main/java/com/vaadin/flow/internal/BrowserLiveReload.java, line 37 at r4 (raw file):
Previously, mehdi-vaadin (Mehdi Javan) wrote…
DetectTrivial: Other methods use third-person verbs.
Done.
joheriks
left a comment
There was a problem hiding this comment.
Reviewable status: 4 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @joheriks and @mehdi-vaadin)
flow-server/src/main/java/com/vaadin/flow/internal/BrowserLiveReloadImpl.java, line 58 at r4 (raw file):
Previously, mehdi-vaadin (Mehdi Javan) wrote…
VaadinService serviceIs this needed?
It is no longer required by the impl, but we are already passing it from other parts of the code such as HotswapAgent code, so I suggest we keep the parameter as it is a kind of API already.
mehdi-vaadin
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r5.
Reviewable status: 3 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @joheriks)
flow-server/src/main/java/com/vaadin/flow/internal/BrowserLiveReload.java, line 44 at r5 (raw file):
Set
Trivial: forgot to mention this one.
flow-server/src/main/java/com/vaadin/flow/internal/BrowserLiveReloadImpl.java, line 58 at r4 (raw file):
Previously, joheriks (Johannes Eriksson) wrote…
It is no longer required by the impl, but we are already passing it from other parts of the code such as HotswapAgent code, so I suggest we keep the parameter as it is a kind of API already.
Does HotswapAgent use BrowserLiveReloadImpl directly? The only usage that I noticed is through BrowserLiveReloadAccess.getLiveReload. If that's the only usage, we can change this class without any problem.
joheriks
left a comment
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @joheriks and @mehdi-vaadin)
flow-server/src/main/java/com/vaadin/flow/internal/BrowserLiveReloadImpl.java, line 58 at r4 (raw file):
Previously, mehdi-vaadin (Mehdi Javan) wrote…
Does HotswapAgent use
BrowserLiveReloadImpldirectly? The only usage that I noticed is throughBrowserLiveReloadAccess.getLiveReload. If that's the only usage, we can change this class without any problem.
Good point, my mistake (I mixed it up with BrowserLiveReloadAccess::getLiveReload which requires the VaadinService parameter). Done.
joheriks
left a comment
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, 0 of 1 LGTMs obtained (waiting on @mehdi-vaadin and @vaadin-bot)
flow-server/src/main/java/com/vaadin/flow/internal/BrowserLiveReloadImpl.java, line 62 at r4 (raw file):
Done.
mehdi-vaadin
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r6.
Dismissed @vaadin-bot from a discussion.
Reviewable status:complete! all discussions resolved, 1 of 1 LGTMs obtained


Fixes #7845.
This change is