Skip to content

End request if hasActiveRequest is true - #11786

Closed
TatuLund wants to merge 1 commit into
masterfrom
fix11702
Closed

TatuLund wants to merge 1 commit into
masterfrom
fix11702

Conversation

@TatuLund

@TatuLund TatuLund commented Nov 2, 2019 •

Copy link
Copy Markdown
Contributor

Fixes #11702


This change is Reviewable

@TatuLund
TatuLund requested a review from Artur- November 4, 2019 12:09
TatuLund added a commit that referenced this pull request Nov 5, 2019
If new request is attempted when resynchronization is ongoing, the Push will stop working. This patch fixes the issue by aborting handleJson if resynch is already ongoing. 

This PR supercedes #11786

Fixes #11702, #7719
@TatuLund

TatuLund commented Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

Closed in favor of #11791

@TatuLund TatuLund closed this Nov 5, 2019
TatuLund added a commit that referenced this pull request Nov 5, 2019
* Fixing issue with Push stopping working in some circumstances

If new request is attempted when resynchronization is ongoing, the Push will stop working. This patch fixes the issue by aborting handleJson if resynch is already ongoing. 

This PR supercedes #11786

Fixes #11702, #7719

* Call onResynchronize() in MessageHandler

* Optimizing
Ansku pushed a commit that referenced this pull request Nov 6, 2019
* Fixing issue with Push stopping working in some circumstances

If new request is attempted when resynchronization is ongoing, the Push will stop working. This patch fixes the issue by aborting handleJson if resynch is already ongoing. 

This PR supercedes #11786

Fixes #11702, #7719

* Call onResynchronize() in MessageHandler

* Optimizing
@Ansku
Ansku deleted the fix11702 branch October 7, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push with websockets fails after reconnecting.

1 participant