Skip to content

feat: add new Fusion generator - #110

Merged
Lodin merged 123 commits into
mainfrom
feat/parser/basic-functionality
Nov 30, 2021
Merged

Lodin merged 123 commits into
mainfrom
feat/parser/basic-functionality

Conversation

@Lodin

@Lodin Lodin commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Address vaadin/flow#9010

This PR introduces a new Fusion generator that works as a Maven and Gradle plugin.

@Lodin Lodin added the hilla Issues related to Hilla label Sep 16, 2021
@Lodin Lodin changed the title feat: add maven plugin & parser initial code feat: add new Fusion generator Sep 16, 2021
Lodin and others added 27 commits September 28, 2021 19:10
Comment thread packages/java/maven-plugin/pom.xml Resolved
Comment thread packages/java/maven-plugin/pom.xml Resolved
Comment thread packages/java/parser-jvm-core/pom.xml Resolved
@Lodin
Lodin requested review from Haprog and platosha November 26, 2021 11:40
@codecov

codecov Bot commented Nov 26, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #110 (6b12c05) into main (19fb8db) will decrease coverage by 7.95%.
The diff coverage is 61.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #110      +/-   ##
============================================
- Coverage     97.90%   89.94%   -7.96%     
- Complexity        0      127     +127     
============================================
  Files            11       39      +28     
  Lines          2483     3174     +691     
  Branches        125      175      +50     
============================================
+ Hits           2431     2855     +424     
- Misses           51      288     +237     
- Partials          1       31      +30     
Flag Coverage Δ
unittests 89.94% <61.36%> (-7.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fusion/parser/core/ArrayRelativeTypeSignature.java 0.00% <0.00%> (ø)
.../com/vaadin/fusion/parser/core/OpenAPIPrinter.java 0.00% <0.00%> (ø)
...com/vaadin/fusion/parser/core/ParserException.java 0.00% <0.00%> (ø)
...ava/com/vaadin/fusion/parser/core/ParserUtils.java 0.00% <0.00%> (ø)
...n/java/com/vaadin/fusion/parser/core/Relative.java 0.00% <0.00%> (ø)
...aadin/fusion/parser/core/RelativeTypeArgument.java 0.00% <0.00%> (ø)
...adin/fusion/parser/core/RelativeTypeParameter.java 0.00% <0.00%> (ø)
...parser/core/TypeVariableRelativeTypeSignature.java 0.00% <0.00%> (ø)
.../fusion/parser/core/BaseRelativeTypeSignature.java 17.64% <17.64%> (ø)
...aadin/fusion/parser/core/AbstractParserConfig.java 18.18% <18.18%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fb8db...6b12c05. Read the comment docs.

platosha
platosha previously approved these changes Nov 26, 2021

@platosha platosha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the structural ideas and similarity between parser and generator. Great job @Lodin!

@haijian-vaadin haijian-vaadin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work, don't have many comments
Could also add license header to the source files

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Haprog Haprog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the Java code but everything else looks ok to me. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hilla Issues related to Hilla

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants