Skip to content

feat: export Signals under own package - #2043

Merged
platosha merged 30 commits into
mainfrom
feat/re-export-signals
Feb 22, 2024
Merged

platosha merged 30 commits into
mainfrom
feat/re-export-signals

Conversation

@cromoteca

Copy link
Copy Markdown
Contributor

Closes #2035

@cromoteca
cromoteca force-pushed the feat/re-export-signals branch from 92f9353 to 8c94625 Compare February 7, 2024 20:47
@cromoteca
cromoteca marked this pull request as ready for review February 8, 2024 09:15
Comment thread packages/ts/react-signals/package.json Resolved
@codecov

codecov Bot commented Feb 8, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cd629a) 95.26% compared to head (5d925e3) 95.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2043   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          57       57           
  Lines        3861     3861           
  Branches      564      564           
=======================================
  Hits         3678     3678           
  Misses        147      147           
  Partials       36       36           
Flag Coverage Δ
unittests 95.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

platosha
platosha previously approved these changes Feb 13, 2024
platosha
platosha previously approved these changes Feb 14, 2024
platosha added a commit to vaadin/flow that referenced this pull request Feb 20, 2024
Vite's esbuild JSX output in production has some incompatibility with the
Preact Signals library. As a workaround, this change applies JSX
transformation provided by `@vitejs/plugin-react` in production mode.

Required by: vaadin/hilla#2043
platosha added a commit to vaadin/flow that referenced this pull request Feb 21, 2024
Vite's esbuild JSX output in production has some incompatibility with the
Preact Signals library. As a workaround, this change applies JSX
transformation provided by `@vitejs/plugin-react` in production mode.

Required by: vaadin/hilla#2043
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
3 New issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha7 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide initial Hilla signals library

4 participants