Repository navigation
chore: add Claude Code and code review workflows - #6165
Merged
Merged
Conversation
Adds two GitHub Actions workflows based on the shared actions in vaadin/github-actions, following the setup in flow, flow-components and web-components: - claude.yml runs Claude Code when a maintainer tags @claude in an issue or PR comment or review. It reuses the repository's setup action for Node, JDK and dependencies, provides Chrome for the browser-based Vitest tests, and allows the Maven, npm, npx and Gradle commands needed to build and test this repository. - code-review.yml reviews pull requests when they are opened or marked ready for review, on a /code-review comment, or on a review request for vaadin-review-bot. PRs opened by the totally-not-ai app are reviewed as well. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6165 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 129 129
Lines 8875 8875
Branches 1369 1369
=======================================
Hits 7657 7657
Misses 1194 1194
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…n actions (#6166) Follow-up fixes to the Claude GitHub workflows added on the base branch. ## TestBench license guard never worked The `Install TestBench license` step was guarded with `if: env.TB_LICENSE != ''`, which can never be true: a step condition sees neither the `secrets` context nor the step's own `env`, so the expression always evaluated to an empty string and the step was silently skipped — the `~/.vaadin/proKey` file was never written, even when the secret was set. The guard now lives inside the script, where the step `env` is actually available, and logs a message when the secret is absent. ## Don't persist credentials when checking out untrusted PR code `code-review.yml` checks out `refs/pull/<n>/head`, i.e. code from an arbitrary contributor, while the job token has write access to issues and pull requests. `actions/checkout` leaves that token in the local git config by default, so anything running in the tree can use it. The checkout now uses `persist-credentials: false`; the review action receives its own token through the `github-token` input, so nothing is lost. ## Pin actions to full commit SHAs SonarQube flags actions referenced by a mutable tag or branch (rule S7637, security vulnerability), which failed the quality gate on the PR that introduced these workflows. `browser-actions/setup-chrome` and the two shared `vaadin/github-actions` actions are now pinned to full commit SHAs, with the readable version kept in a trailing comment — the same convention `codecov-action` already uses in `validation.yml`. --------- Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
|
Artur-
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adds the Claude Code (
@claude) and code review workflows, using the shared actions from vaadin/github-actions with the same triggers and eligibility rules as inflow-componentsandweb-components.Repo-specific parts:
claude.ymlreuses.github/actions/setupfor the toolchain, provides Chrome for the browser-based Vitest tests (CHROME_BIN, as invalidation.yml), and installs the TestBench license. Allowed tools on top of the base list:mvn,npm ci/npm install,npm run/npm test,npx nx|vitest|tsc|eslint|prettier, and the Gradle wrappers. Nothing is prebuilt; the injected instructions tell Claude that cross-package TypeScript tests neednpm run buildfirst and to avoid running the integration test suites wholesale.code-review.ymlalso reviews PRs opened by thetotally-not-aiapp. The app is not an org member, so the check job allows it explicitly.vaadin/flowas a read-only reference checkout.id-token: write, which the code-review action does not use.Requires the
ANTHROPIC_API_KEYsecret and the org secretVAADIN_REVIEW_BOTto be shared with this repository.Type of change