Repository navigation
chore: build Gradle plugin on JDK 25+ with Gradle 9.8.0 - #6410
Merged
Merged
Conversation
The Gradle plugin module failed to build on JDK 25 and later, because Dokka 1.x does not run there. The plugin marker module (pom-portal.xml) was only part of the build on JDK 22 and earlier, and was skipped without a message on newer JDKs. For users the plugin does not change: it still needs Java 21 and Gradle 8.14 or later. - Upgrade the Gradle wrapper of hilla-gradle-plugin from 8.14.3 to 9.8.0 - Replace Dokka 1.9.0 with dokka-javadoc 2.2.0 - Put the Gradle API on the unit test classpath, as Gradle 9 no longer does it - Use Property<String> for the optional mainClass input, as Gradle 9 API nullness annotations reject Property<String?> - Add @DisableCachingByDefault to EngineGenerateTask and EngineConfigureTask, as validatePlugins now requires; neither task was cached before - Replace the deprecated createTempDir in the functional tests - Remove the JDK-activated gradle profile and build pom-portal.xml as a regular module Mirrors vaadin/flow#25989.
Artur-
approved these changes
Sep 29, 2026
Contributor
Author
|
The build seems broken by recent changes in flow-components and platform (vaadin/platform#9413). |
Contributor
Author
|
Waiting for #6313 |
ZheSun88
approved these changes
Sep 29, 2026
ZheSun88
enabled auto-merge (squash)
September 29, 2026 09:03
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6410 +/- ##
============================================
+ Coverage 81.29% 81.31% +0.02%
Complexity 2018 2018
============================================
Files 343 343
Lines 14816 14816
Branches 2107 2107
============================================
+ Hits 12044 12048 +4
+ Misses 2479 2477 -2
+ Partials 293 291 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZheSun88
pushed a commit
to vaadin/platform
that referenced
this pull request
Sep 29, 2026
Upgrade the Gradle wrapper of vaadin-gradle-plugin from 8.14 to 9.8.0, as vaadin/flow#25989 and vaadin/hilla#6410 do for their plugins. Only the plugin build changes: the classes still target Java 21, and user projects still need Gradle 8.14 or later. - Replace Dokka 1.9.20 with dokka-javadoc 2.2.0 - Configure the archive name and Java compatibility through the base and java extensions, as Gradle 9 removes the conventions - Import groovy.xml.XmlSlurper, use assignment syntax, and move the Kotlin JVM target to compilerOptions - Add the Gradle API to the unit test classpath
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The Hilla Gradle plugin module could not be built on JDK 25 and later, and its plugin marker module (
pom-portal.xml) was silently skipped on JDK 23 and later. This applies to Hilla the same fix as vaadin/flow#25989. For users nothing changes: the plugin still needs Java 21 and Gradle 8.14 or later.Risks:
gradleMaven profile is gone, sopom-portal.xmlis now built on every JDK. A build that passes-P '!gradle'now builds the Gradle plugin; use-pl '!:hilla-gradle-plugin,!:com.vaadin.hilla.gradle.plugin'instead. No workflow in this repository uses it.Changes:
hilla-gradle-pluginfrom 8.14.3 to 9.8.0. It still uses the-bindistribution, and thewrapperblock now saysBINto match.dokka-javadoc2.2.0, because Dokka 1.x fails on JDK 25 and later.mainClassinput ofEngineGenerateTasktoProperty<String>, because Gradle 9's JSpecify annotations rejectProperty<String?>.set(null)still works.@DisableCachingByDefaulttoEngineGenerateTaskandEngineConfigureTask, whichvalidatePluginsnow requires. Neither task was cached before.createTempDirin the functional tests.gradleprofile and madepom-portal.xmla regular module.Tested locally:
mvn install -pl :hilla-gradle-plugin,:com.vaadin.hilla.gradle.pluginon JDK 25 and on JDK 21, including the Dokka javadoc jarkotlin-gradle-testintegration testsFollow-up: CI only runs the functional tests on Gradle 8.14. A Gradle 9.x run like Flow's
GradleVersionSupportTestwould cover that 9.x keeps working.