Repository navigation
fix: clear bound state on service destroy and guard observation hooks - #435
Merged
Merged
Conversation
Clear the static registry, insights buffers and UI state growth source when the service that bound them is destroyed, so a redeploy or DevTools restart does not keep the previous deployment in memory. Catch failures from the HTTP observation hooks so a throwing hook no longer leaves the request scope or observation open on the thread. Related: #430
heruan
reviewed
Oct 5, 2026
Only clear the active registry when the last service bound to the registry is destroyed.
heruan
approved these changes
Oct 5, 2026
caalador
added a commit
that referenced
this pull request
Oct 6, 2026
…#435) (CP: 5.0) (#448) This PR cherry-picks changes from the original PR #435 to branch 5.0. --- #### Original PR description > Clear the static registry, insights > buffers and UI state growth source > when the service that bound them is > destroyed, so a redeploy or DevTools > restart does not keep the previous > deployment in memory. > > Catch failures from the HTTP observation > hooks so a throwing hook no longer > leaves the request scope or observation > open on the thread. > > Related: #430 > Co-authored-by: caalador <mikael.grankvist@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the static registry, insights
buffers and UI state growth source
when the service that bound them is
destroyed, so a redeploy or DevTools
restart does not keep the previous
deployment in memory.
Catch failures from the HTTP observation
hooks so a throwing hook no longer
leaves the request scope or observation
open on the thread.
Related: #430