Repository navigation
refactor: time session locks from Flow lock events - #450
Merged
Merged
Conversation
Flow 25.4 reports the wait time on SessionLockAcquiredEvent and the hold time on SessionLockReleasedEvent. Record those durations instead of timing the lock in thread locals, and stop listening for SessionLockRequestedEvent. Wait time is now also measured for tryLock and lockInterruptibly, where Flow fires the requested event only after the lock is taken, so the old measurement was always close to zero. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
heruan
marked this pull request as ready for review
October 14, 2026 07:59
heruan
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review risk: two-way door — only the
vaadin.session.lock.waitandvaadin.session.lock.holdtimers; names and tags are unchanged.Summary
The session lock timers now record the wait and hold times that Flow 25.4 reports on
SessionLockAcquiredEventandSessionLockReleasedEvent, instead of timing the lock in thread locals.What changed
SessionLockMetricsBinderrecordsgetWaitTime()andgetHoldTime()from the events and no longer keepswaitStart/holdStartthread locals.SessionLockRequestedEvent.tryLockandlockInterruptiblyare now real. Flow fires the requested event for these only after the lock is taken, so the old measurement was always close to zero.Test summary
accessandrequestcontext tags.Part of #416
🤖 Generated with Claude Code