Skip to content

chore: replace deprecated includePatterns with includeGlobs - #350

Merged
Artur- merged 1 commit into
mainfrom
chore/replace-deprecated-api
Sep 24, 2026
Merged

Artur- merged 1 commit into
mainfrom
chore/replace-deprecated-api

Conversation

@mcollovati

Copy link
Copy Markdown
Contributor

refactor · deployment · native image builds

Background — native image resources. A native executable contains
only the classpath resources registered at build time. Quarkus
extensions register them as regular expressions or as globs, and the
reachability metadata format used from GraalVM/Mandrel 25 accepts only
globs.

Resources that Vaadin reads at runtime in native mode are now
registered as globs instead of regular expressions, which Quarkus has
deprecated for removal. The files included in the image stay the same.

Risks:

  • ✅ No breaking, behaviour, API, security, memory, serialization,
    threading, performance or migration impact

  • Registered the Atmosphere version, Vaadin version and feature flags
    properties with includeGlobs instead of the deprecated
    includePatterns

    • The globs translate to the same regular expressions, so the
      generated resource-config.json is unchanged
  • Added a test that checks the three properties files are included

Regex resource patterns are deprecated for removal in Quarkus, since
the reachability metadata used from GraalVM/Mandrel 25 accepts only
globs. The literal paths translate to the same regexes, so the
generated resource configuration is unchanged.
@mcollovati

Copy link
Copy Markdown
Contributor Author

Type of change

  • Internal change

@mcollovati
mcollovati marked this pull request as ready for review September 24, 2026 09:16
@github-actions

Copy link
Copy Markdown

Test Results

119 files  119 suites   6m 21s ⏱️
200 tests 197 ✅  3 💤 0 ❌
493 runs  481 ✅ 12 💤 0 ❌

Results for commit 816072d.

@sonarqubecloud

Copy link
Copy Markdown

@Artur-
Artur- merged commit 8857ae1 into main Sep 24, 2026
14 checks passed
@Artur-
Artur- deleted the chore/replace-deprecated-api branch September 24, 2026 10:56
totally-not-ai Bot added a commit to vaadin/flow that referenced this pull request Sep 24, 2026
Brings in the two commits that landed upstream since the last catch-up,
again through the upstream history so blame reaches them:

- replace deprecated includePatterns with includeGlobs (vaadin/quarkus#350):
  GraalVM/Mandrel 25 reachability metadata accepts only globs, and the
  literal paths translate to the same patterns, so the generated resource
  configuration is unchanged
- replace deprecated Jandex and Flow API (vaadin/quarkus#351)

The only conflict was in VaadinQuarkusNativeProcessorTest, where upstream
added a test for the runtime-loaded properties next to the JavaScript
definition test this branch had already replaced with one that drives the
build step. Both are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Artur- added a commit to vaadin/flow that referenced this pull request Sep 25, 2026
…f Flow (#25736)

## Summary
This PR moves the Vaadin Quarkus extension from the separate
`vaadin/quarkus` repository into Flow. It is now built, tested and
released with Flow and uses Flow's version number. Changes to Flow are
now tested against Quarkus in the same pull request, not later in
another repository.

## What changed
**Behavior change (release and versioning):**
`com.vaadin:vaadin-quarkus` and `com.vaadin:vaadin-quarkus-deployment`
now use Flow's version (`25.4-SNAPSHOT` for now), not the extension's
own `1.0`–`3.1` numbering. `flow-bom` now manages both artifacts. This
affects anyone who sets the extension version by hand. The Java packages
(`com.vaadin.quarkus.*`) and classes are the same as in
`vaadin/quarkus`, so application code does not change.

- **Extension:** new top-level module `vaadin-quarkus` with `runtime`
(the extension) and `deployment` (the Quarkus build steps). It is
imported with its upstream git history, so `git blame` still works. It
includes the latest upstream commits (vaadin/quarkus#350,
vaadin/quarkus#351). The root POM adds `quarkus.version` 3.33.0.
- **Test suite:** new `flow-tests/vaadin-quarkus-tests` with
`production`, `development`, `embedded-plugin`, `push-dispatch-it`,
`codestarts` and their fixtures. It is not in the `flow-tests` reactor
on purpose. The Quarkus Maven extension would otherwise load for every
build of the repository. Cleanups done during the import:
- `@{argLine}` is added to the surefire and failsafe argLines, so
Quarkus can pass its JVM options. `failsafe.argLine` gets an empty
default.
- Deprecated test API is replaced, for example `first()` → `single()`
and `attribute("id", …)` → `withId(…)`.
- The obsolete `productionMode` setting, the `webdrivermanager` profile
and the `java11` profile are removed.
  - `quarkus-junit5` is replaced by `quarkus-junit`.
- **CI (`validation.yml` and `computeMatrix.js`):** a new
`quarkus-tests` job runs one leg per test module. Each module sets
`validation.run` in its POM:
  - `always`: `embedded-plugin`, `production`, `codestarts`
  - `when-changed`: runs only when the Quarkus sources change
  - Modules without the property are fixtures and get no job.
- **New workflows:**
- `quarkus-native.yml`: a nightly GraalVM native image build. It runs
only in `vaadin/flow`.
- `quarkus-ecosystem-ci.yml`: builds the extension against the Quarkus
main snapshot. For this to work, `quarkusio/quarkus-ecosystem-ci` must
point to this repository, and the `ECOSYSTEM_CI_TOKEN` secret must be
set here.
- **Node.js and pnpm versions:** `scripts/frontendToolVersions.sh` now
reads them from `FrontendTools`. CI now uses the same versions a Flow
application gets. The Quarkus jobs used Node.js 24.21.0 before and now
use 26.10.0.
- **`@since` tags:** `update-since-tags.yml` now also reconciles
`@since` tags for `vaadin-quarkus`.
- **Docs:** `CLAUDE.md`, `guidelines/repository.md` and the suite README
now describe the new module.

## API Changes
No existing Flow API changes. The new `vaadin-quarkus` module adds the
public API that the `com.vaadin:vaadin-quarkus` extension already had,
with no API changes:

### com.vaadin.quarkus (runtime)
```java
// Added (moved unchanged from vaadin/quarkus)
public class QuarkusVaadinServlet
public class QuarkusVaadinServletService
public class QuarkusInstantiator
public class QuarkusInstantiatorFactory
public class QuarkusResourceProvider
public @interface EnableWebsockets
// plus the com.vaadin.quarkus.annotation scopes (@UIScoped, @NormalUIScoped,
// @RouteScoped, @NormalRouteScoped, @RouteScopeOwner, @VaadinServiceEnabled,
// @VaadinServiceScoped, @VaadinSessionScoped) and the com.vaadin.quarkus.context,
// .graal and .push support classes
```

### com.vaadin.quarkus.deployment (deployment)
```java
// Added (moved unchanged from vaadin/quarkus)
public class VaadinQuarkusProcessor
public class VaadinQuarkusNativeProcessor
// plus the com.vaadin.quarkus.deployment.vaadinplugin and .nativebuild build-step classes
```

## Test summary
**Quarkus extension (JVM):**
- App starts and serves views in production and development mode
- App builds through the embedded Vaadin plugin
- Push dispatch does not deadlock
- CDI scopes, instantiator, i18n, add-ons and a theme from a jar work

**Codestarts:**
- Generated project matches the snapshots, for release and pre-release
versions

**Native image:**
- Embedded-plugin suite runs as a native image (nightly, not per PR)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matti Tahvonen <matti@vaadin.com>
Co-authored-by: Mikael Grankvist <mikael.grankvist@vaadin.com>
Co-authored-by: Pekka Hyvönen <pekka@vaadin.com>
Co-authored-by: Denis <denis@vaadin.com>
Co-authored-by: ZheSun88 <zhe@vaadin.com>
Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
Co-authored-by: Marco Collovati <mcollovati@gmail.com>
Co-authored-by: Marco Collovati <marco@vaadin.com>
Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
Co-authored-by: Konstantin Gribov <grossws@gmail.com>
Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Co-authored-by: marcin <106965834+MarcinVaadin@users.noreply.github.com>
Co-authored-by: marcin <marcin@vaadin.com>
Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>
Co-authored-by: Mikael Grankvist <mgrankvi@vaadin.com>
Co-authored-by: Tomi Virtanen <tltv@vaadin.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
Co-authored-by: caalador <mikael.grankvist@gmail.com>
Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Co-authored-by: Artur Signell <artur@vaadin.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants