Skip to content

Undeprecate "theme" property #32

Closed

Description

@platosha

The theme property is marked as deprecated in web components, however using the attribute should be allowed.

Currently it is confusingly deprecated for React wrappers. It should be safe to keep theme prop supported without deprecation, as the property support removal from the component would not make any impact for React users.

Activity

  1. web-padawan commented on Nov 15, 2022

    @web-padawan
    Member

    Please note that theme property was deprecated intentionally, see vaadin/web-components#3529

    ThemePropertyMixin allows specifying themes only via the theme attribute. However, since ThemePropertyMixin also defines a protected read-only property theme, it makes both Svelte and Vue consider that the theme attribute must be set via that property, which doesn't work because the property is read-only.

    In React wrappers it doesn't make sense to have this property as deprecated, you can just use attribute.

  2. self-assigned this
    on Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions