Repository navigation
fix: Scrolling quickly to the bottom shows blank items - #978
Merged
Merged
Conversation
When the dropdown was being scrolled quickly, some pages weren't being loaded and skipped in the end. It's fixed by resending the skipped pages after the scroller reset and filter those indexes which are close to current scroller position, so as to avoid unnecessary duplicated pages and loading indicator hanging. Fixes: #970
mshabarov
marked this pull request as ready for review
December 3, 2020 11:34
tomivirkki
approved these changes
Dec 3, 2020
tomivirkki
left a comment
Member
There was a problem hiding this comment.
The hotfix LGTM, we agreed to add the tests afterward.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the dropdown was being scrolled quickly, some pages weren't being loaded and skipped in the end. It's fixed by resending the skipped pages after the scroller reset and filter those indexes which are close to current scroller position, so as to avoid unnecessary duplicated pages and loading indicator hanging.
Fixes: #970
In draft still, because need to cover these changes by a tests.