Skip to content

fix: Scrolling quickly to the bottom shows blank items - #978

Merged
mshabarov merged 5 commits into
masterfrom
fix-fast-scroll
Dec 4, 2020
Merged

mshabarov merged 5 commits into
masterfrom
fix-fast-scroll

Conversation

@mshabarov

Copy link
Copy Markdown
Collaborator

When the dropdown was being scrolled quickly, some pages weren't being loaded and skipped in the end. It's fixed by resending the skipped pages after the scroller reset and filter those indexes which are close to current scroller position, so as to avoid unnecessary duplicated pages and loading indicator hanging.

Fixes: #970

In draft still, because need to cover these changes by a tests.

tomivirkki and others added 5 commits November 25, 2020 17:53
When the dropdown was being scrolled quickly, some pages weren't being loaded and skipped in the end. It's fixed by resending the skipped pages after the scroller reset and filter those indexes which are close to current scroller position, so as to avoid unnecessary duplicated pages and loading indicator hanging.

Fixes: #970
@mshabarov
mshabarov marked this pull request as ready for review December 3, 2020 11:34

@tomivirkki tomivirkki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hotfix LGTM, we agreed to add the tests afterward.

@mshabarov
mshabarov merged commit a3385b6 into master Dec 4, 2020
@mshabarov
mshabarov deleted the fix-fast-scroll branch December 4, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrolling quickly to the bottom of the dropdown shows blank items

2 participants