Skip to content

Add validation - #29

Merged
yuriy-fix merged 13 commits into
masterfrom
validation
Feb 20, 2020
Merged

yuriy-fix merged 13 commits into
masterfrom
validation

Conversation

@yuriy-fix

Copy link
Copy Markdown
Contributor

Fixes #17

@yuriy-fix
yuriy-fix marked this pull request as ready for review February 5, 2020 10:07
@yuriy-fix
yuriy-fix requested a review from Haprog February 5, 2020 10:07
Comment thread test/validation.html Resolved
Comment thread test/validation.html Resolved
Comment thread test/validation.html Resolved
Comment thread test/validation.html Resolved
Comment thread test/validation.html Resolved
Comment thread test/validation.html Resolved
Comment thread src/vaadin-date-time-picker.html Resolved
Comment thread src/vaadin-date-time-picker.html Resolved

@Haprog Haprog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed you already fixed some of the issues I mentioned in my earlier review so I marked those as resolved already. Here are some thought about the latest commit, but also some of the issues from my previous review are still waiting.

Comment thread test/propagated-properties.html Resolved
Comment thread test/propagated-properties.html Resolved
Comment thread src/vaadin-date-time-picker.html Resolved
Comment thread src/vaadin-date-time-picker.html Resolved

@Haprog Haprog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few new minor issues. Couple of places have some duplicated code that can be removed. Marked some earlier things as resolved.

Comment thread src/vaadin-date-time-picker.html Resolved
Comment thread src/vaadin-date-time-picker.html Resolved
Comment thread test/validation.html Resolved

@Haprog Haprog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems to be working almost perfectly now (except for minor issue with custom field has-value). Requesting few minor updates still.

Comment thread src/vaadin-date-time-picker.html Resolved
Comment thread src/vaadin-date-time-picker.html Resolved
Comment thread test/basic.html Resolved
Comment thread src/vaadin-date-time-picker.html Resolved
Comment thread src/vaadin-date-time-picker.html Resolved

@Haprog Haprog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but found few places where text could be improved a bit and one simple test case should be added.

Comment thread test/basic.html Resolved
Comment thread test/basic.html Resolved

@Haprog Haprog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! One minor test issue left.

Comment thread test/basic.html Resolved

@Haprog Haprog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yuriy-fix
yuriy-fix merged commit 0540c64 into master Feb 20, 2020
@alvarezguille
alvarezguille deleted the validation branch April 6, 2020 13:23
@cla-assistant

cla-assistant Bot commented Oct 31, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant cla-assistant Bot deleted a comment from claassistantio Oct 31, 2026
@cla-assistant

cla-assistant Bot commented Nov 2, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant cla-assistant Bot deleted a comment from claassistantio Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement validation

2 participants