Repository navigation
Add validation - #29
Conversation
Haprog
left a comment
There was a problem hiding this comment.
I noticed you already fixed some of the issues I mentioned in my earlier review so I marked those as resolved already. Here are some thought about the latest commit, but also some of the issues from my previous review are still waiting.
Haprog
left a comment
There was a problem hiding this comment.
Few new minor issues. Couple of places have some duplicated code that can be removed. Marked some earlier things as resolved.
Haprog
left a comment
There was a problem hiding this comment.
Functionality seems to be working almost perfectly now (except for minor issue with custom field has-value). Requesting few minor updates still.
Haprog
left a comment
There was a problem hiding this comment.
Looks good, but found few places where text could be improved a bit and one simple test case should be added.
Haprog
left a comment
There was a problem hiding this comment.
Thanks for the updates! One minor test issue left.
|
|
|
|
Fixes #17