Skip to content

Commit 07fcb38

Browse files
authored
refactor: enforce hiding confirm dialog host element (#3598)
1 parent 7b91ec7 commit 07fcb38

2 files changed

Lines changed: 14 additions & 4 deletions

File tree

‎packages/confirm-dialog/src/vaadin-confirm-dialog.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,7 @@ class ConfirmDialog extends SlotMixin(ElementMixin(ThemePropertyMixin(PolymerEle
6868
static get template() {
6969
return html`
7070
<style>
71-
:host {
72-
display: none;
73-
}
74-
71+
:host,
7572
[hidden] {
7673
display: none !important;
7774
}

‎packages/confirm-dialog/test/confirm-dialog.test.js‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,19 @@ describe('vaadin-confirm-dialog', () => {
2222
});
2323
});
2424

25+
describe('host element', () => {
26+
let confirm;
27+
28+
beforeEach(() => {
29+
confirm = fixtureSync('<vaadin-confirm-dialog></vaadin-confirm-dialog>');
30+
});
31+
32+
it('should enforce display: none to hide the host element', () => {
33+
confirm.style.display = 'block';
34+
expect(getComputedStyle(confirm).display).to.equal('none');
35+
});
36+
});
37+
2538
describe('properties', () => {
2639
let confirm, dialog, overlay;
2740

0 commit comments

Comments
 (0)