Skip to content

refactor: enforce hiding confirm dialog host element - #3598

Merged
web-padawan merged 1 commit into
masterfrom
refactor/hide-confirm-dialog
Mar 23, 2022
Merged

web-padawan merged 1 commit into
masterfrom
refactor/hide-confirm-dialog

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Related to vaadin/flow-components#2909

We'd like to fix HasStyle in ConfirmDialog so that users would be able to set classes on the host element and then they would be propagated to the vaadin-confirm-dialog-overlay element for styling.

So we need to enforce display: none to ensure that setting CSS class on the host would not have any side effects.

Type of change

  • Refactor

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants