Skip to content

Commit f50d8c2

Browse files
authored
fix: remove target listeners when popover is detached (#7694)
1 parent 3ab597b commit f50d8c2

2 files changed

Lines changed: 69 additions & 0 deletions

File tree

‎packages/popover/src/vaadin-popover-target-mixin.js‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,24 @@ export const PopoverTargetMixin = (superClass) =>
3939
};
4040
}
4141

42+
/** @protected */
43+
connectedCallback() {
44+
super.connectedCallback();
45+
46+
if (this.target) {
47+
this._addTargetListeners(this.target);
48+
}
49+
}
50+
51+
/** @protected */
52+
disconnectedCallback() {
53+
super.disconnectedCallback();
54+
55+
if (this.target) {
56+
this._removeTargetListeners(this.target);
57+
}
58+
}
59+
4260
/** @private */
4361
__forChanged(forId) {
4462
if (forId) {

‎packages/popover/test/trigger.test.js‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,23 @@ describe('trigger', () => {
6161
expect(overlay.opened).to.be.false;
6262
});
6363

64+
it('should not open on target click when detached', async () => {
65+
popover.remove();
66+
target.click();
67+
await nextRender();
68+
expect(overlay.opened).to.be.false;
69+
});
70+
71+
it('should open on target click when re-attached', async () => {
72+
popover.remove();
73+
await nextRender();
74+
target.parentNode.appendChild(popover);
75+
76+
target.click();
77+
await nextRender();
78+
expect(overlay.opened).to.be.true;
79+
});
80+
6481
it('should not open on target mouseenter', async () => {
6582
mouseenter(target);
6683
await nextRender();
@@ -131,6 +148,23 @@ describe('trigger', () => {
131148

132149
expect(overlay.opened).to.be.true;
133150
});
151+
152+
it('should not open on target mouseenter when detached', async () => {
153+
popover.remove();
154+
mouseenter(target);
155+
await nextRender();
156+
expect(overlay.opened).to.be.false;
157+
});
158+
159+
it('should open on target mouseenter when re-attached', async () => {
160+
popover.remove();
161+
await nextRender();
162+
target.parentNode.appendChild(popover);
163+
164+
mouseenter(target);
165+
await nextRender();
166+
expect(overlay.opened).to.be.true;
167+
});
134168
});
135169

136170
describe('focus', () => {
@@ -206,6 +240,23 @@ describe('trigger', () => {
206240
expect(overlay.opened).to.be.true;
207241
});
208242

243+
it('should not open on target focusin when detached', async () => {
244+
popover.remove();
245+
focusin(target);
246+
await nextRender();
247+
expect(overlay.opened).to.be.false;
248+
});
249+
250+
it('should open on target focusin when re-attached', async () => {
251+
popover.remove();
252+
await nextRender();
253+
target.parentNode.appendChild(popover);
254+
255+
focusin(target);
256+
await nextRender();
257+
expect(overlay.opened).to.be.true;
258+
});
259+
209260
describe('overlay mousedown', () => {
210261
let input;
211262

0 commit comments

Comments
 (0)