Repository navigation
fix: remove target listeners when popover is detached - #7694
Merged
Merged
Conversation
|
sissbruecker
approved these changes
Aug 26, 2024
Collaborator
|
This ticket/PR has been released with Vaadin 24.5.0.alpha12 and is also targeting the upcoming stable 24.5.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes #7683
This removes
targetevent listeners whenvaadin-popoveris disconnected from the DOM, and restores them in case it is re-connected later.Type of change
Note
There might be a case when
targetis set before addingvaadin-popoverto the DOM, causing event listeners to be added twice. According to the spec this is not a problem as duplicate listeners are discarded:I tested this manually and confirmed this doesn't cause problems, so I think we don't need to have some flags to prevent it.