You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Lighthouse warning: Buttons do not have an accessible name #866
I tested this with axe and it reports following accessibility violations:
---
Rule: aria-allowed-role
Impact: minor
ARIA role must be appropriate for the element (https://dequeuniversity.com/rules/axe/3.4/aria-allowed-role?application=axeAPI)
Issue target: vaadin-drawer-toggle,button
Context: <button type="button" role="presentation" tabindex="0"></button>
Fix any of the following:
ARIA role presentation is not allowed for given element
---
Rule: button-name
Impact: critical
Buttons must have discernible text (https://dequeuniversity.com/rules/axe/3.4/button-name?application=axeAPI)
Issue target: vaadin-drawer-toggle
Context: <vaadin-drawer-toggle tabindex="0" role="button"></vaadin-drawer-toggle>
Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element's default semantics were not overridden with role="presentation" Element's default semantics were not overridden with role="none"
Element has no title attribute or the title attribute is empty
---
When trying to use aria-hidden there is another error:
Accessibility Violations
---
Rule: aria-hidden-focus
Impact: serious
ARIA hidden element must not contain focusable elements (https://dequeuniversity.com/rules/axe/3.4/aria-hidden-focus?application=axeAPI)
Issue target: vaadin-drawer-toggle,button
Context: <button type="button" aria-hidden="true" tabindex="0"></button>
Fix all of the following:
Focusable content should be disabled or be removed from the DOM
Regardless of that, VoiceOver on Safari properly handles role="button" on the host element (which is vaadin-drawer-toggle or vaadin-button - both use the same structure).
Activity
web-padawan commentedon Jul 5, 2018
Apparently, latest Lighthouse beta changed the a11y audit and there are new warnings. We need to check other components too.
abdonrd commentedon Jul 5, 2018
@web-padawan thanks! Anyway, I have used the stable Lighthouse v3.0.0.
web-padawan commentedon Jul 5, 2018
Confirmed this warning with the Lighthouse 3.0.1 (available as a Chrome extension)
Note that Chrome builtin audit in DevTools still uses 2.9.1
abdonrd commentedon Jul 31, 2018
Any news here? Thanks in advance!
aarondrabeck commentedon Sep 14, 2018
+1
aarondrabeck commentedon Nov 28, 2018
+1
Haprog commentedon Apr 10, 2019
Reopening this, as the previous fix had to be reverted (c451eaa) to fix a performance regression (#128)
chrisgo67 commentedon Sep 26, 2019
Any news on this?
What is the status with Vaadin 14 components?
1 remaining item
web-padawan commentedon Jan 29, 2020
I tested this with
axeand it reports following accessibility violations:When trying to use
aria-hiddenthere is another error:Regardless of that, VoiceOver on Safari properly handles
role="button"on the host element (which isvaadin-drawer-toggleorvaadin-button- both use the same structure).web-padawan commentedon Jan 29, 2020
Note: the original decision to use this roles structure was done 2 years ago:
See the comments
I have tried to revert
role="presentation"and tested it with VoiceOver on Mac OS Mojave:When adding
aria-label="toggle"to the drawer toggle, Chrome works correctly.web-padawan commentedon Mar 9, 2020
See https://www.w3.org/TR/using-aria/#fifthrule for the actual issue.
anezthes commentedon Apr 3, 2020
See vaadin/vaadin-button#144 (comment).
juuso-vaadin commentedon Apr 6, 2021
Did some testing and buttons are announced as they should when using
Button label is not announced at all in
I don't have access to JAWS at the moment.
Current workaround is to manually set the aria-label.
In Flow this is done with
button.getElement().setAttribute("aria-label", "Click me");web-padawan commentedon Sep 19, 2021
Closing as fixed by #2394. I have created a separate ticket for testing - see #2571.