You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[button] Consider removing internal stylable parts #955
The stylable parts (prefix, suffix, and label) I introduced a while ago don’t really make much sense semantically. I’m considering we should remove them.
That said, removing them means that themes can’t target them, and that in turn makes it difficult to make baseline alignment work like it does currently, because we would only be able ot set the font-size and line-height on the host (which affects the baseline alignment).
Activity
[-]Button should not have internal stylable parts[/-][+][button] Consider removing internal stylable parts[/+]web-padawan commentedon Aug 23, 2021
We have discussed this and agreed about the following:
slotelements for styling and instead style slotted content directlyslot[name='prefix'] ::slotted(*)to apply margins etclabelpart (already removed in the new implementation)buttonpart exposed byvaadin-buttoncomponent.