Skip to content

refactor: update RTE to use base styles, cleanup Lumo CSS - #10056

Merged
web-padawan merged 3 commits into
mainfrom
refactor/lumo-rte-use-base-styles
Aug 22, 2025
Merged

web-padawan merged 3 commits into
mainfrom
refactor/lumo-rte-use-base-styles

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Added includeBaseStyles: true to rich-text-editor.

Type of change

  • Refactor

@web-padawan
web-padawan requested review from jouni and vursen August 22, 2025 09:43
padding: 0.125rem 0.25rem;
}

pre {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this CSS as Quill 2 uses .ql-code-block-container and does not render pre elements.

Comment on lines +12 to +15
background: transparent;
border: none;
color: inherit;
border-radius: 0;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to override base styles defaults.

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan removed the request for review from jouni August 22, 2025 12:06
@web-padawan
web-padawan merged commit 0f42625 into main Aug 22, 2025
@web-padawan
web-padawan deleted the refactor/lumo-rte-use-base-styles branch August 22, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants