Skip to content

fix: make popover width and height work when set before attach - #10077

Merged
web-padawan merged 2 commits into
mainfrom
fix/popover-dimensions
Aug 27, 2025
Merged

web-padawan merged 2 commits into
mainfrom
fix/popover-dimensions

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fix for a regression in vaadin-popover: after removal of OverlayClassMixin the __sizeChanged observer stopped to work as the _overlayElement is no longer a reactive property. Aligned the logic with DialogSizeMixin and added tests.

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan removed the request for review from sissbruecker August 27, 2025 06:44
@web-padawan
web-padawan merged commit 5968279 into main Aug 27, 2025
@web-padawan
web-padawan deleted the fix/popover-dimensions branch August 27, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants