Skip to content

refactor: update date-picker overlay content to use base styles - #10087

Merged
web-padawan merged 1 commit into
mainfrom
refactor/lumo-date-picker-overlay-content-base-styles
Aug 28, 2025
Merged

web-padawan merged 1 commit into
mainfrom
refactor/lumo-date-picker-overlay-content-base-styles

Conversation

@web-padawan

@web-padawan web-padawan commented Aug 26, 2025 •

Copy link
Copy Markdown
Member

Description

  • Updated vaadin-date-picker-overlay-content Lumo CSS to use base styles.
  • Added missing style for year scroller indicator in RTL and updated screenshots.

Type of change

  • Refactor

@web-padawan
web-padawan requested review from jouni and vursen August 26, 2025 17:33
@web-padawan
web-padawan force-pushed the refactor/lumo-date-picker-overlay-content-base-styles branch from a7eead7 to e0c0bb3 Compare August 26, 2025 17:39
:host([dir='rtl']) ::slotted([slot='years'])::before {
right: 0;
transform: translate(75%, -50%) rotate(45deg);
border-bottom-left-radius: var(--lumo-border-radius-s);

@web-padawan web-padawan Aug 26, 2025 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing for the year indicator triangle in RTL so I added it. Could use rotate: -45deg instead.

@web-padawan
web-padawan force-pushed the refactor/lumo-date-picker-overlay-content-base-styles branch 3 times, most recently from 693ae31 to 705bd7f Compare August 26, 2025 17:53
@web-padawan
web-padawan force-pushed the refactor/lumo-date-picker-overlay-content-base-styles branch from 705bd7f to 0b2e213 Compare August 27, 2025 06:44
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan removed the request for review from vursen August 28, 2025 10:48
@web-padawan
web-padawan merged commit ecf4bce into main Aug 28, 2025
@web-padawan
web-padawan deleted the refactor/lumo-date-picker-overlay-content-base-styles branch August 28, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants