Repository navigation
refactor: simplify logic that prevents instant scroll chaining - #10128
Merged
Merged
Conversation
1 task done
vursen
force-pushed
the
simplify-overscroll-prevention-logic
branch
from
September 5, 2025 11:30
1d229ba to
83b4b70
Compare
vursen
force-pushed
the
simplify-overscroll-prevention-logic
branch
from
September 5, 2025 12:10
4a9f204 to
438d143
Compare
vursen
commented
Sep 5, 2025
| expect(wrapper.scrollTop).to.equal(0); | ||
| it('should prevent outer scrolling right after reaching the end', () => { | ||
| scrollTarget.scrollTop = scrollTarget.scrollHeight; | ||
| expect(scrollTarget.style.overscrollBehavior).to.equal('none'); |
Contributor
Author
There was a problem hiding this comment.
I tried implementing a mouseWheel WTR command but I couldn't get it to work in Playwright – the tests just got stuck, so I fell back to this basic test.
vursen
force-pushed
the
simplify-overscroll-prevention-logic
branch
from
September 5, 2025 12:24
438d143 to
7d2b483
Compare
|
web-padawan
reviewed
Sep 5, 2025
web-padawan
left a comment
Member
There was a problem hiding this comment.
I wonder if we could also replace __patchWheelOverScrolling in combo-box scroller with overscroll-behavior?
Contributor
Author
Hmm, good idea! |
tomivirkki
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR replaces the custom mouse wheel logic that prevented instant scroll chaining at the end of the virtualized list with an
overscroll-behavior: noneapplied while scrolling and cleared after a short timeout once scrolling finishes. This simplifies the logic while ensuring that multiple touchpad swipes required to get to the end of a large grid still don't accidentally cause the whole page to scroll. Bonus: it now works on touch devices too.Type of change