Skip to content

refactor: define all LumoInjector-related styles on ::before - #10171

Merged
web-padawan merged 1 commit into
mainfrom
get-rid-of-css-var-mess
Sep 15, 2025
Merged

web-padawan merged 1 commit into
mainfrom
get-rid-of-css-var-mess

Conversation

@vursen

@vursen vursen commented Sep 15, 2025 •

Copy link
Copy Markdown
Contributor

Description

The PR ensures all LumoInjector-related CSS properties are defined on the ::before pseudo-element to avoid cluttering the DOM inspector:

image

Depends on

Type of change

  • Refactor

@vursen vursen changed the title refactor: define all Lumo injector related CSS on ::before refactor: define all Lumo injector related styles on ::before Sep 15, 2025
@vursen
vursen requested a review from web-padawan September 15, 2025 09:06
@sonarqubecloud

Copy link
Copy Markdown

@vursen vursen changed the title refactor: define all Lumo injector related styles on ::before refactor: define all Lumo-injector-related styles on ::before Sep 15, 2025
@vursen vursen changed the title refactor: define all Lumo-injector-related styles on ::before refactor: define all LumoInjector-related styles on ::before Sep 15, 2025
@vursen
vursen requested a review from jouni September 15, 2025 09:48
@web-padawan
web-padawan removed the request for review from jouni September 15, 2025 10:51
@web-padawan
web-padawan merged commit 5bd72a3 into main Sep 15, 2025
@web-padawan
web-padawan deleted the get-rid-of-css-var-mess branch September 15, 2025 10:51
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants