Skip to content

fix: prevent dialog shrinking on the right edge - #10400

Merged
web-padawan merged 2 commits into
24.9from
fix-prevent-dialog-shrinking-on-the-right-edge
Oct 28, 2025
Merged

web-padawan merged 2 commits into
24.9from
fix-prevent-dialog-shrinking-on-the-right-edge

Conversation

@ugur-vaadin

Copy link
Copy Markdown
Contributor

Description

This PR adds the style width: max-content to the overlay in order to prevent the dialog from shrinking when dragged on the right edge.

Fixes #10391

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change affected the Material screenshots but not Lumo, I will check what happens there.

@web-padawan
web-padawan force-pushed the fix-prevent-dialog-shrinking-on-the-right-edge branch from 5fbf512 to 19a11b8 Compare October 28, 2025 13:33
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan removed the request for review from vursen October 28, 2025 13:37
@web-padawan
web-padawan merged commit e169e4d into 24.9 Oct 28, 2025
@web-padawan
web-padawan deleted the fix-prevent-dialog-shrinking-on-the-right-edge branch October 28, 2025 13:37
vaadin-bot pushed a commit that referenced this pull request Oct 28, 2025
Co-authored-by: web-padawan <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Oct 28, 2025
Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Co-authored-by: web-padawan <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.9.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants