Skip to content

test: fix TypeScript warnings in dashboard unit tests - #10888

Merged
web-padawan merged 1 commit into
mainfrom
test/dashboard-ts-fixes
Jan 8, 2026
Merged

web-padawan merged 1 commit into
mainfrom
test/dashboard-ts-fixes

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixed some TS compilation warnings to make type check pass with dashboard tests.

Type of change

  • Test


it('should prevent selection while resizing', async () => {
const propertyName = isSafari ? 'WebkitUserSelect' : 'userSelect';
const propertyName = isSafari ? 'webkitUserSelect' : 'userSelect';

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it appears that Safari supports both values, but TS only supports the camelCase one:

Screenshot 2026-01-08 at 10 25 20

@sonarqubecloud

sonarqubecloud Bot commented Jan 8, 2026

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 3696d89 into main Jan 8, 2026
10 checks passed
@web-padawan
web-padawan deleted the test/dashboard-ts-fixes branch January 8, 2026 08:44
web-padawan added a commit that referenced this pull request Jan 8, 2026
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.1.0-alpha1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants