Skip to content

chore: run visual tests for external contributions - #11031

Merged
sissbruecker merged 2 commits into
mainfrom
chore/run-visual-tests-for-external-contributions
Jan 30, 2026
Merged

sissbruecker merged 2 commits into
mainfrom
chore/run-visual-tests-for-external-contributions

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Allow passing SauceLabs secrets to visual test workflows run from forks. Workflow runs still need manual approval from maintainers, and changes must be reviewed beforehand to verify that there is no malicious code that could exfiltrate the secrets.

This is similar to how the Testbench license is handled in the Flow repo.

@sissbruecker
sissbruecker requested a review from ZheSun88 January 29, 2026 09:34
@web-padawan

Copy link
Copy Markdown
Member

Lumo Expected — Waiting for status to be reported

Seems like the PR status check is pending?

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

@ZheSun88

Copy link
Copy Markdown
Member

added the checkout, to get the changes from PR branch.

for the usage of pull_request_target, we need to merge this PR to test whether it works or not.
otherwise, the build will just pending here, as the same test in target branch is triggered by pull_request, not pull_request_target

@sissbruecker
sissbruecker merged commit e1f1801 into main Jan 30, 2026
6 of 7 checks passed
@sissbruecker
sissbruecker deleted the chore/run-visual-tests-for-external-contributions branch January 30, 2026 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants