Repository navigation
docs: add i18n getter override and improve i18n JSDoc for upload - #11382
Merged
Merged
Conversation
…onents Add i18n getter/setter with @type override to UploadFileListMixin so CEM can resolve the specific UploadFileListI18n type. Add full default i18n structure to JSDoc in both .js and .d.ts. Also add missing fileTooLarge to UploadMixin i18n JSDoc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
web-padawan
requested review from
sissbruecker and
tomivirkki
and removed request for
tomivirkki
March 20, 2026 08:32
sissbruecker
approved these changes
Mar 23, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
…onents (#11382) Add i18n getter/setter with @type override to UploadFileListMixin so CEM can resolve the specific UploadFileListI18n type. Add full default i18n structure to JSDoc in both .js and .d.ts. Also add missing fileTooLarge to UploadMixin i18n JSDoc. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
@type {!UploadFileListI18n}override toUploadFileListMixinso the CEM analyzer can resolve the specific type instead of genericObject.jsand.d.tsforUploadFileListMixinfileTooLargetoUploadMixini18n JSDoc in both.jsand.d.tsTest plan
yarn release:cemand verify no errorspackages/upload/custom-elements.json—UploadFileListMixinshould havei18nmember with description🤖 Generated with Claude Code
Note
The
i18noverride is fixing the API docs forvaadin-upload-file-listthat currently have this: