Skip to content

docs: add i18n getter override and improve i18n JSDoc for upload - #11382

Merged
sissbruecker merged 1 commit into
mainfrom
refactor/upload-file-list-i18n
Mar 23, 2026
Merged

sissbruecker merged 1 commit into
mainfrom
refactor/upload-file-list-i18n

Conversation

@web-padawan

@web-padawan web-padawan commented Mar 20, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add i18n getter/setter with @type {!UploadFileListI18n} override to UploadFileListMixin so the CEM analyzer can resolve the specific type instead of generic Object
  • Add full default i18n structure to JSDoc in both .js and .d.ts for UploadFileListMixin
  • Add missing fileTooLarge to UploadMixin i18n JSDoc in both .js and .d.ts

Test plan

  • Run yarn release:cem and verify no errors
  • Check packages/upload/custom-elements.json — UploadFileListMixin should have i18n member with description

🤖 Generated with Claude Code

Note

The i18n override is fixing the API docs for vaadin-upload-file-list that currently have this:

Screenshot 2026-03-20 at 10 30 56

…onents

Add i18n getter/setter with @type override to UploadFileListMixin so
CEM can resolve the specific UploadFileListI18n type. Add full default
i18n structure to JSDoc in both .js and .d.ts. Also add missing
fileTooLarge to UploadMixin i18n JSDoc.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan requested review from sissbruecker and tomivirkki and removed request for tomivirkki March 20, 2026 08:32
@sissbruecker
sissbruecker merged commit 8a1eec4 into main Mar 23, 2026
10 checks passed
@sissbruecker
sissbruecker deleted the refactor/upload-file-list-i18n branch March 23, 2026 09:41
vaadin-bot pushed a commit that referenced this pull request Mar 23, 2026
…onents (#11382)

Add i18n getter/setter with @type override to UploadFileListMixin so
CEM can resolve the specific UploadFileListI18n type. Add full default
i18n structure to JSDoc in both .js and .d.ts. Also add missing
fileTooLarge to UploadMixin i18n JSDoc.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants