Repository navigation
feat: add headingLevel property to accordion - #12133
Merged
Merged
Conversation
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the changes — left 2 comments.
| Finding | |
|---|---|
| 🧹 | __headingLevelChanged hand-rolls attribute delegation that DelegateStateMixin already provides. |
| 👀 | No test swaps the summary node at runtime after headingLevel is set, so re-applying aria-level to a new heading is never exercised. |
web-padawan
force-pushed
the
claude/issue-6900-20260714-1242
branch
2 times, most recently
from
July 14, 2026 13:19
98c82a6 to
510a8d8
Compare
web-padawan
force-pushed
the
claude/issue-6900-20260714-1242
branch
2 times, most recently
from
July 15, 2026 07:35
16ca4fe to
01f20b8
Compare
web-padawan
force-pushed
the
claude/issue-6900-20260714-1242
branch
from
July 15, 2026 07:37
01f20b8 to
6122cde
Compare
DiegoCardoso
approved these changes
Jul 15, 2026
|
web-padawan
added a commit
that referenced
this pull request
Jul 15, 2026
The accordion set aria-level directly on each panel heading from its own updated() callback. When a panel heading was created or replaced later (a default heading, summary set after attach, or a swapped element), nothing re-applied the level, so it was silently dropped. In Firefox the heading could also be missing during the initial updated(), which threw. Propagate headingLevel to each panel and let the panel delegate it to its heading as the aria-level attribute via DelegateStateMixin, which re-applies the value whenever the heading element changes. Follow-up to #12133
This was referenced Sep 4, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.3.0. |
3 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Adds a
headingLevelproperty tovaadin-accordion-panelthat sets thearia-levelattribute on thevaadin-accordion-headingelement, so the heading can be exposed at the level matching the page structure.Part of #6900
Generated with Claude Code