Skip to content

feat: aura overlay animations - #12147

Merged
web-padawan merged 8 commits into
mainfrom
feat/aura-overlay-animations
Jul 31, 2026
Merged

web-padawan merged 8 commits into
mainfrom
feat/aura-overlay-animations

Conversation

@jouni

@jouni jouni commented Jul 15, 2026 •

Copy link
Copy Markdown
Member

Add overlay animations for dialogs and picker components (selects, combo-boxex, date-pickers, etc).

Depends on #12120

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes — left 7 comments.

Finding
⚠️ :host:not([opening], [closing]) ties the hiding rule with the opened rule, so an open CRUD dialog gets display: none.
⚠️ Notification card base styles now animate in every theme, running on top of Lumo's existing notification animations.
🧹 overlayAnimationProperties restates by hand the 11 property names already listed in the registerCSSProperty calls above it.
👀 The manual overlay-property re-inherit block is special-cased in a leaf Pro component instead of the shared DialogBaseMixin.
⚡ Notification open/close transitions layout properties (height, max-height, margins) instead of transform/opacity.
🧹 The two @supports branches duplicate the same transition-duration and margin: 0 closing reset.
👀 The css-utils import omits the .js extension that every other import of that module uses.

Comment thread packages/crud/src/vaadin-crud-dialog.js Resolved
Comment thread packages/crud/src/vaadin-crud-dialog.js Resolved
@jouni
jouni force-pushed the feat/aura-overlay-animations branch from cad634c to 7149c07 Compare July 16, 2026 07:13
@web-padawan
web-padawan force-pushed the feat/aura-overlay-animations branch from 7149c07 to 83ffeb3 Compare July 29, 2026 05:43

vaadin-dialog,
vaadin-confirm-dialog,
vaadin-crud {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: the closing attribute is not set on vaadin-crud since #12255 so this won't work. I wonder if we should set closing on both crud and dialog?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated accordingly.

@web-padawan web-padawan left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: there are some overlay components that use overlayStyles but get no Aura animation: avatar-group, breadcrumbs, login-overlay, rich-text-editor-popup,slider-bubble, tooltip, user-tags.

Should we cover some of those in this PR or are they intentionally excluded for now?

@web-padawan
web-padawan force-pushed the feat/aura-overlay-animations branch from 4a2643d to 9b1040b Compare July 29, 2026 07:23
@jouni

jouni commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

Should we cover some of those in this PR or are they intentionally excluded for now?

I think I only focused on the most impactful components first. I’ll review these and see if they could use animations.

@jouni
jouni force-pushed the feat/aura-overlay-animations branch from 9b1040b to a61c054 Compare July 30, 2026 07:07
Comment thread packages/aura/aura.css Resolved
@web-padawan
web-padawan force-pushed the feat/aura-overlay-animations branch from a61c054 to 2d36f82 Compare July 30, 2026 07:44
@jouni

jouni commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

there are some overlay components that use overlayStyles but get no Aura animation: avatar-group, breadcrumbs, login-overlay, rich-text-editor-popup,slider-bubble, tooltip, user-tags.

Added animations to login-overlay, avatar-group, breadcrumbs, and rich-text-editor. I think tooltips can be instantaneous, and slider-bubble and user-tags are essentially tooltips IMO.

jouni and others added 4 commits July 30, 2026 11:06
The state attributes are set on the overlay and its owner, which for crud is the
internal vaadin-crud-dialog element and not the vaadin-crud host, so the nested
[closing] rule never applied. Crud keeps the unconditional values, which do reach
the overlay part through the forwarding in vaadin-crud-dialog.
@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 844e07d into main Jul 31, 2026
15 of 16 checks passed
@web-padawan
web-padawan deleted the feat/aura-overlay-animations branch July 31, 2026 14:30
vursen pushed a commit that referenced this pull request Aug 5, 2026
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.3.0-alpha8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants