Repository navigation
feat: aura overlay animations - #12147
Conversation
vaadin-review-bot
left a comment
There was a problem hiding this comment.
Reviewed the changes — left 7 comments.
| Finding | |
|---|---|
:host:not([opening], [closing]) ties the hiding rule with the opened rule, so an open CRUD dialog gets display: none. |
|
| Notification card base styles now animate in every theme, running on top of Lumo's existing notification animations. | |
| 🧹 | overlayAnimationProperties restates by hand the 11 property names already listed in the registerCSSProperty calls above it. |
| 👀 | The manual overlay-property re-inherit block is special-cased in a leaf Pro component instead of the shared DialogBaseMixin. |
| ⚡ | Notification open/close transitions layout properties (height, max-height, margins) instead of transform/opacity. |
| 🧹 | The two @supports branches duplicate the same transition-duration and margin: 0 closing reset. |
| 👀 | The css-utils import omits the .js extension that every other import of that module uses. |
cad634c to
7149c07
Compare
7149c07 to
83ffeb3
Compare
|
|
||
| vaadin-dialog, | ||
| vaadin-confirm-dialog, | ||
| vaadin-crud { |
There was a problem hiding this comment.
note: the closing attribute is not set on vaadin-crud since #12255 so this won't work. I wonder if we should set closing on both crud and dialog?
There was a problem hiding this comment.
Note: there are some overlay components that use overlayStyles but get no Aura animation: avatar-group, breadcrumbs, login-overlay, rich-text-editor-popup,slider-bubble, tooltip, user-tags.
Should we cover some of those in this PR or are they intentionally excluded for now?
4a2643d to
9b1040b
Compare
I think I only focused on the most impactful components first. I’ll review these and see if they could use animations. |
9b1040b to
a61c054
Compare
a61c054 to
2d36f82
Compare
Added animations to login-overlay, avatar-group, breadcrumbs, and rich-text-editor. I think tooltips can be instantaneous, and slider-bubble and user-tags are essentially tooltips IMO. |
The state attributes are set on the overlay and its owner, which for crud is the internal vaadin-crud-dialog element and not the vaadin-crud host, so the nested [closing] rule never applied. Crud keeps the unconditional values, which do reach the overlay part through the forwarding in vaadin-crud-dialog.
|
|
This ticket/PR has been released with Vaadin 25.3.0-alpha8. |



Add overlay animations for dialogs and picker components (selects, combo-boxex, date-pickers, etc).
Depends on #12120