Repository navigation
feat: resolve icon aliases defined with use element in iconset - #12473
Merged
Merged
Conversation
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the changes — left 2 comments.
| Finding | |
|---|---|
| Alias chains resolve or break depending on document order, because the loop reads the same map it mutates | |
| 🧪 | The alias test's only meaningful assertion inspects the private _icons map, and the other one cannot fail |
web-padawan
force-pushed
the
feat/iconset-aliases
branch
2 times, most recently
from
August 24, 2026 08:38
22f5816 to
c915b63
Compare
An iconset entry that contains a single `<use href="#...">` pointing at another entry in the same iconset is now mapped to that entry. This allows the Vaadin iconset to expose new names for existing icons without duplicating the SVG content. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
web-padawan
force-pushed
the
feat/iconset-aliases
branch
from
August 24, 2026 08:42
c915b63 to
b11cfee
Compare
|
jouni
approved these changes
Aug 24, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.3.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Extracted from #12452
Iconset: an entry that contains a single<use href="#...">pointing at another entry now resolves to the entry it points at.@vaadin/iconswhile keeping the old names working.vaadin-icon.Type of change
How to test
dev/icon.html.🤖 Generated with Claude Code