Skip to content

test: parametrize menu-bar overflow tests by direction and collapse order (#12792) (CP: 25.3) - #12799

Merged
web-padawan merged 1 commit into
25.3from
cherry-pick-12792-to-25.3-1790060601789
Sep 22, 2026
Merged

web-padawan merged 1 commit into
25.3from
cherry-pick-12792-to-25.3-1790060601789

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #12792 to branch 25.3.


Original PR description

Description

Depends on #12791

  • Wrapped the geometry tests in a loop over ltr and rtl, with nested suites for the default order, reverseCollapse and the end-aligned theme, so every case runs in both directions instead of only the two that had a duplicated in RTL copy
  • Replaced the per-button assertions with an expectCollapsed helper that asserts the whole collapsed set, the overflow button and has-single-button from one list of indexes
  • Labelled every assertion, so a failure reads button 3: expected 'visible' to equal 'hidden' under a suite path that names the direction and the collapse order
  • Built the items per fixture instead of sharing one module-level array
  • Removed the duplicated in RTL tests and the separate reverse-collapse suite, both absorbed by the direction loop

Type of change

  • Tests

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 4586d45 into 25.3 Sep 22, 2026
11 checks passed
@web-padawan
web-padawan deleted the cherry-pick-12792-to-25.3-1790060601789 branch September 22, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants