Skip to content

test: animate the dialog in the menu-bar overflow integration test - #12809

Merged
web-padawan merged 1 commit into
mainfrom
test/dialog-menu-bar-animation
Sep 22, 2026
Merged

web-padawan merged 1 commit into
mainfrom
test/dialog-menu-bar-animation

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Follow-up to #7347
Related to #7338

The test guards against the menu bar measuring itself while the dialog opening animation scales the overlay. It imports base styles, which do not animate, so the dialog opened without a transform and the test passed even with the loop that #7347 replaced. The 25.3 overlay animation properties make it possible to turn the animation on from the test itself.

  • Enabled the opening animation with --vaadin-overlay-animation-duration, --vaadin-overlay-animation-delay and --vaadin-overlay-scale-closed, the values Lumo uses
    • With the delay, the overlay sits at scale(0.95) while the menu bar runs its first detection
  • Changed the dialog width from 650px to 620px, a width where the pre-fix: detect overflow correctly when used in a dialog #7347 loop leaves the overflow button outside the menu bar
  • Asserted the overflow items with items.slice(6) instead of two indexed checks

Type of change

  • Tests

🤖 Generated with Claude Code

The test guards against measuring the menu bar while the dialog opening
animation scales the overlay, see #7338. It imports base styles, which do
not animate, so it no longer covered that case. Turn the animation on with
the overlay animation properties, the way Lumo does, and use a width where
the pre-#7347 loop leaves the overflow button outside the menu bar.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

@web-padawan
web-padawan removed the request for review from vursen September 22, 2026 13:06
@web-padawan
web-padawan merged commit b5eeb9f into main Sep 22, 2026
18 checks passed
@web-padawan
web-padawan deleted the test/dialog-menu-bar-animation branch September 22, 2026 13:06
web-padawan added a commit that referenced this pull request Sep 22, 2026
…12809) (#12810)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants