Repository navigation
test: animate the dialog in the menu-bar overflow integration test - #12809
Merged
Merged
Conversation
The test guards against measuring the menu bar while the dialog opening animation scales the overlay, see #7338. It imports base styles, which do not animate, so it no longer covered that case. Turn the animation on with the overlay animation properties, the way Lumo does, and use a width where the pre-#7347 loop leaves the overflow button outside the menu bar. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
DiegoCardoso
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Follow-up to #7347
Related to #7338
The test guards against the menu bar measuring itself while the dialog opening animation scales the overlay. It imports base styles, which do not animate, so the dialog opened without a transform and the test passed even with the loop that #7347 replaced. The 25.3 overlay animation properties make it possible to turn the animation on from the test itself.
--vaadin-overlay-animation-duration,--vaadin-overlay-animation-delayand--vaadin-overlay-scale-closed, the values Lumo usesscale(0.95)while the menu bar runs its first detectionitems.slice(6)instead of two indexed checksType of change
🤖 Generated with Claude Code