Repository navigation
refactor: extract private method for time-picker step truncation - #12856
Merged
Merged
Conversation
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
web-padawan
force-pushed
the
refactor/time-picker-truncate-time
branch
from
September 26, 2026 08:12
ef27c34 to
be31fc6
Compare
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
web-padawan
force-pushed
the
refactor/time-picker-truncate-time
branch
from
September 26, 2026 08:28
be31fc6 to
2cf70d8
Compare
|
web-padawan
requested review from
DiegoCardoso and
sissbruecker
and removed request for
DiegoCardoso
September 28, 2026 07:28
sissbruecker
approved these changes
Sep 28, 2026
web-padawan
added a commit
that referenced
this pull request
Sep 28, 2026
) (#12863) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Updated all places that truncate a time object to the step resolution to use one method.
__truncateTime(time)method toTimePickerMixinthat wrapsvalidateTime(time, this.step)__getTimeObject,__setValueFromTimeand__generateDropdownListthrough__truncateTimestepcopy, which only differs fromthis.stepwhen the latter is unset and defaults to3600. Both give minute precision, so the item values do not change.Also changed to use "truncated" instead of "stripped" as it feels more appropriate.
Type of change
🤖 Generated with Claude Code