Skip to content

fix: mirror overflow chip stack and remove button in RTL (#12951) (CP: 25.2) - #12953

Merged
sissbruecker merged 1 commit into
25.2from
fix/mscb-overflow-chip-rtl-25.2
Oct 2, 2026
Merged

sissbruecker merged 1 commit into
25.2from
fix/mscb-overflow-chip-rtl-25.2

Conversation

@web-padawan

Copy link
Copy Markdown
Member

This PR cherry-picks changes from the original PR #12951 to branch 25.2.


Description

Related to #12950

In RTL, the overflow chip of the multi-select combo box reserves space for its stacked lines with margin-inline-start, but the lines were offset with the physical left, so they were drawn on the wrong side: inside the chip in base styles and Aura, over the neighbour chip in Lumo. The remove button was nudged with a physical translate and overlapped the label.

  • Replaced left with inset-inline-start for the ::before and ::after lines of the overflow chip in base styles and Lumo
  • Replaced border-left with border-inline-start in the Lumo chip styles
  • Mirrored the remove button translate in RTL in the base chip styles
  • Added a visual test with an overflow chip in RTL for base styles, Lumo and Aura
    • LTR baselines are unchanged

Type of change

  • Bugfix

How to test

  1. Open dev/multi-select-combo-box.html and set dir="rtl" on <html>
  2. Select enough items for the overflow chip to show with a count of 3 or more
  3. The stacked lines appear on the right side of the overflow chip, in the gap before the field edge, and the remove button has a gap to the label

🤖 Generated with Claude Code

…: 25.2)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 1, 2026

Copy link
Copy Markdown

@sissbruecker
sissbruecker merged commit ee91dfe into 25.2 Oct 2, 2026
10 checks passed
@sissbruecker
sissbruecker deleted the fix/mscb-overflow-chip-rtl-25.2 branch October 2, 2026 06:11
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.2.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants