Skip to content

test: remove iOS-only context-menu tests and body margin setup - #13023

Merged
web-padawan merged 1 commit into
mainfrom
test/context-menu-remove-ios-viewport-tests
Oct 8, 2026
Merged

web-padawan merged 1 commit into
mainfrom
test/context-menu-remove-ios-viewport-tests

Conversation

@web-padawan

@web-padawan web-padawan commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Description

  • Removed the <vaadin-overlay> iOS viewport workaround (phone mode) tests from overlay.test.js
    • They only run on iOS, so CI always skips them. overlay/test/basic.test.js covers --vaadin-overlay-viewport-bottom
  • Removed document.body.style.margin from the RTL before / after hooks
    • The test runner page already sets body { margin: 0 } in getTestRunnerHtml (wtr-utils.js)

Type of change

  • Tests

🤖 Generated with Claude Code

@web-padawan web-padawan changed the title test: remove iOS-only context-menu viewport tests and body margin setup test: remove iOS-only context-menu tests and body margin setup Oct 8, 2026

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

@web-padawan
web-padawan force-pushed the test/context-menu-remove-ios-viewport-tests branch from f3d54c9 to d637602 Compare October 8, 2026 04:48
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@web-padawan
web-padawan force-pushed the test/context-menu-remove-ios-viewport-tests branch from d637602 to 73c461e Compare October 8, 2026 04:55
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@web-padawan
web-padawan removed the request for review from DiegoCardoso October 8, 2026 08:13
@web-padawan
web-padawan merged commit 1a40e8d into main Oct 8, 2026
15 checks passed
@web-padawan
web-padawan deleted the test/context-menu-remove-ios-viewport-tests branch October 8, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants