Skip to content

refactor: remove details cell height update from resize handler - #13037

Merged
web-padawan merged 2 commits into
mainfrom
refactor/grid-resize-details-cell-heights
Oct 8, 2026
Merged

web-padawan merged 2 commits into
mainfrom
refactor/grid-resize-details-cell-heights

Conversation

@vursen

@vursen vursen commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

The PR removes the _updateDetailsCellHeights() call from _resizeHandler and the method itself.

  • _resizeHandler runs from _renderColumnTree, where every body row was just updated through __updateRow (which updates the details cell height on its own), and from the column resize handler, where the details cell ResizeObserver picks up any height change
  • The call is left over from when _resizeHandler was the iron-list host resize hook and the details cell had no ResizeObserver

Type of change

  • Refactor

🤖 Generated with Claude Code

_renderColumnTree already updates every row through __updateRow, and the
details cell ResizeObserver covers height changes from column resizing.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@vursen
vursen marked this pull request as ready for review October 8, 2026 11:57

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@web-padawan
web-padawan removed the request for review from sissbruecker October 8, 2026 12:13
@web-padawan
web-padawan merged commit 6ed230f into main Oct 8, 2026
12 checks passed
@web-padawan
web-padawan deleted the refactor/grid-resize-details-cell-heights branch October 8, 2026 12:13
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.4.0-alpha3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants