Repository navigation
refactor: remove details cell height update from resize handler - #13037
Merged
Merged
Conversation
_renderColumnTree already updates every row through __updateRow, and the details cell ResizeObserver covers height changes from column resizing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
vursen
marked this pull request as ready for review
October 8, 2026 11:57
tomivirkki
approved these changes
Oct 8, 2026
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
web-padawan
approved these changes
Oct 8, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.4.0-alpha3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The PR removes the
_updateDetailsCellHeights()call from_resizeHandlerand the method itself._resizeHandlerruns from_renderColumnTree, where every body row was just updated through__updateRow(which updates the details cell height on its own), and from the column resize handler, where the details cellResizeObserverpicks up any height change_resizeHandlerwas the iron-list host resize hook and the details cell had noResizeObserverType of change
🤖 Generated with Claude Code