Skip to content

fix!: use div for confirm-dialog and crud dialog footer (#13082) (CP: 25.2) - #13103

Merged
web-padawan merged 1 commit into
25.2from
cherry-pick-13082-to-25.2-1791884604023
Oct 13, 2026
Merged

web-padawan merged 1 commit into
25.2from
cherry-pick-13082-to-25.2-1791884604023

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #13082 to branch 25.2.


Description

Part of #13081

The toolbar role is not allowed on <footer>, see ARIA in HTML, and axe reports it as aria-allowed-role. Browsers still apply the role, so NVDA, JAWS and VoiceOver announce the toolbar the same before and after this change.

  • Replaced <footer part="footer" role="toolbar"> with <div part="footer" role="toolbar"> in the confirm-dialog and crud dialog overlays
    • Part names are unchanged, so styling is not affected

Type of change

  • Bugfix

[!WARNING]
The footer of the confirm-dialog and crud dialog overlays is now a <div> element. Styles that select it by tag name, such as footer[part='footer'], no longer match. Use the part name instead.

🤖 Generated with Claude Code

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 687f8da into 25.2 Oct 13, 2026
10 checks passed
@web-padawan
web-padawan deleted the cherry-pick-13082-to-25.2-1791884604023 branch October 13, 2026 09:52
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 25.2.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants