Repository navigation
fix: update frozen cell positions when grid direction changes - #13186
Merged
Merged
Conversation
tomivirkki
marked this pull request as draft
October 20, 2026 08:01
tomivirkki
marked this pull request as ready for review
October 20, 2026 08:02
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the changes — left 1 comment.
| Finding | |
|---|---|
| Only the cell transforms are reset, the header/footer/items transforms are also stale when scrollWidth is measured |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the changes — left 2 comments.
| Finding | |
|---|---|
| With lazy column rendering the direction change still leaves cells mispositioned | |
| 🧪 | The frozen (start) cell half of the fix has no test coverage |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tomivirkki
force-pushed
the
fix/grid-frozen-to-end-column-is
branch
from
October 20, 2026 08:42
0af25f5 to
6bec4c5
Compare
vursen
reviewed
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vursen
reviewed
Oct 20, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
vursen
approved these changes
Oct 20, 2026
web-padawan
pushed a commit
that referenced
this pull request
Oct 20, 2026
#13194) Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
This ticket/PR has been released with Vaadin 25.4.0-alpha4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



When the direction changes while a grid is shown, the frozen cells keep the transforms that were calculated for the previous direction.
Kapture.2026-10-20.at.09.40.07.mp4
These transforms place the frozen-to-end cells outside the table and increase its scroll width, so recalculating the scroll position is not enough on its own: the transforms have to be reset first.
dirof the grid changesType of change