Skip to content

test: clean up select disabled tests covered by snapshots (#13249) (CP: 25.3) - #13261

Merged
web-padawan merged 1 commit into
25.3from
cherry-pick-13249-to-25.3-1792998427056
Oct 26, 2026
Merged

web-padawan merged 1 commit into
25.3from
cherry-pick-13249-to-25.3-1792998427056

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #13249 to branch 25.3.


Description

  • Removed the value button disabled check from select.test.js, the disabled DOM snapshot already pins disabled, aria-disabled and tabindex="-1" on the button
  • Stopped setting readonly in the "disallow programmatic opening when disabled" test
    • With both flags set the test duplicated the readonly suite and never covered the disabled path alone

Type of change

  • Tests

🤖 Generated with Claude Code

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 8f8cc2e into 25.3 Oct 26, 2026
12 checks passed
@web-padawan
web-padawan deleted the cherry-pick-13249-to-25.3-1792998427056 branch October 26, 2026 07:45
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 25.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants