Repository navigation
test: add script and generated fixtures for pdf-viewer tests - #13268
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the changes — left 3 comments.
| Finding | |
|---|---|
| The Chromium-printed fixtures embed Arial subsets, so they do contain third-party content and are not reproducible across machines | |
| 📝 | The unsafe-links fixture treats ftp: and tel: as URLs the viewer must block, which contradicts pdf.js defaults |
| 🧪 | The "link over two lines" is one tall annotation, not the per-line annotations real producers emit |
vursen
reviewed
Oct 26, 2026
vursen
approved these changes
Oct 26, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vursen
reviewed
Oct 26, 2026
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.4.0-alpha5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Part of #7669
<vaadin-pdf-viewer>unit tests underpackages/pdf-viewer/test/fixtures/, plus aninvalid.pdftext filejavascript:link, a JavaScriptOpenAction, a rotated page and encryptiongenerate-fixtures.js, which creates every fixture from HTML printed with Playwright's Chromium or writes it by handNo test uses the fixtures yet. The unit tests of the next PRs load them.
Type of change
How to test
node packages/pdf-viewer/test/fixtures/generate-fixtures.jsgit status🤖 Generated with Claude Code