Skip to content

chore: align code review eligibility with vaadin/docs - #13347

Merged
web-padawan merged 1 commit into
mainfrom
chore/align-code-review-eligibility
Nov 3, 2026
Merged

web-padawan merged 1 commit into
mainfrom
chore/align-code-review-eligibility

Conversation

@web-padawan

@web-padawan web-padawan commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Description

Aligned the code review workflow with vaadin/docs: the review runs only for pull requests from branches of this repository.

  • The pre-filter skips pull request events from forks.
  • The check job skips a /code-review comment on a pull request from a fork. It reads isCrossRepository of the pull request, so the job also gets pull-requests: read.

Type of change

Internal change.

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@web-padawan
web-padawan merged commit 58d6095 into main Nov 3, 2026
20 checks passed
@web-padawan
web-padawan deleted the chore/align-code-review-eligibility branch November 3, 2026 12:42
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.4.0-alpha6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants