Repository navigation
test: add Aura size variant visual tests for button and badge - #13370
Merged
Merged
Conversation
|
web-padawan
marked this pull request as ready for review
November 6, 2026 12:11
vaadin-review-bot
approved these changes
Nov 6, 2026
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
Risk: 🟢 low — Test-only change that adds four Aura visual tests with matching default and dark baselines; no production code is touched and the new screenshots cannot affect any existing suite.
Approved automatically: a test change with low risk and no findings.
web-padawan
pushed a commit
that referenced
this pull request
Nov 6, 2026
#13371) Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Collaborator
|
This ticket/PR has been released with Vaadin 25.4.0-alpha6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Review risk: two-way door — test-only change, adds Aura visual tests and baselines for two components.
Summary
Adds Aura visual tests for the
smallandlargesize variants ofvaadin-buttonandvaadin-badge. Size variants change--aura-base-size/--aura-base-font-size, and Aura re-declares the derived font size, line height, gap and padding tokens on elements with athemeattribute so that they are recomputed for the variant (see #11228). No Aura visual test used these variants on button or badge so far, so a change to those rules (as considered in #13357) could break the sizing without any failing screenshot.What changed
button(Aura): newsizesuite withsmallandlargescreenshots.badge(Aura): newsizesuite withsmallandlargescreenshots.Test summary
:where([theme])token rules intypography.cssandsize.cssremoved locally, all four new tests fail.Working on behalf of Serhii