Skip to content

test: add Aura size variant visual tests for button and badge - #13370

Merged
web-padawan merged 1 commit into
mainfrom
test/aura-size-variants-button-badge
Nov 6, 2026
Merged

web-padawan merged 1 commit into
mainfrom
test/aura-size-variants-button-badge

Conversation

@totally-not-ai

@totally-not-ai totally-not-ai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Review risk: two-way door — test-only change, adds Aura visual tests and baselines for two components.

Summary

Adds Aura visual tests for the small and large size variants of vaadin-button and vaadin-badge. Size variants change --aura-base-size / --aura-base-font-size, and Aura re-declares the derived font size, line height, gap and padding tokens on elements with a theme attribute so that they are recomputed for the variant (see #11228). No Aura visual test used these variants on button or badge so far, so a change to those rules (as considered in #13357) could break the sizing without any failing screenshot.

What changed

  • button (Aura): new size suite with small and large screenshots.
  • badge (Aura): new size suite with small and large screenshots.
  • Baselines added for the default and dark modes. No production code changes.

Test summary

  • The new screenshots differ in size from the default ones (e.g. button 86px / 92px / 101px wide for small / default / large).
  • With the :where([theme]) token rules in typography.css and size.css removed locally, all four new tests fail.

Working on behalf of Serhii

@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

@web-padawan
web-padawan marked this pull request as ready for review November 6, 2026 12:11

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

Risk: 🟢 low — Test-only change that adds four Aura visual tests with matching default and dark baselines; no production code is touched and the new screenshots cannot affect any existing suite.

Approved automatically: a test change with low risk and no findings.

@web-padawan
web-padawan merged commit a18937e into main Nov 6, 2026
27 checks passed
@web-padawan
web-padawan deleted the test/aura-size-variants-button-badge branch November 6, 2026 12:40
web-padawan pushed a commit that referenced this pull request Nov 6, 2026
#13371)

Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.4.0-alpha6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants