Skip to content

refactor: remove dead code from pdf-viewer - #13391

Merged
web-padawan merged 4 commits into
mainfrom
refactor/pdf-viewer-dead-code
Nov 11, 2026
Merged

web-padawan merged 4 commits into
mainfrom
refactor/pdf-viewer-dead-code

Conversation

@totally-not-ai

@totally-not-ai totally-not-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes dead code from the experimental <vaadin-pdf-viewer> package.

What changed

  • getVisiblePages() no longer returns the visible height of each page. Nothing read it; the current page and render order only use ratio. The internal PdfViewerVisiblePage type is updated to match. This is not public API.
  • No behavior change for applications.

Test summary

  • Updated the layout unit tests to the new visible-page shape.
  • The pdf-viewer unit tests, lint and type check pass.

Working on behalf of Serhii

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan marked this pull request as ready for review November 11, 2026 19:05

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

Risk: 🟢 low — Removal of an unused field from an internal, non-exported helper in an experimental package, with every consumer verified to read only index and ratio and the tests updated in step.

@web-padawan
web-padawan merged commit bb73ce2 into main Nov 11, 2026
22 checks passed
@web-padawan
web-padawan deleted the refactor/pdf-viewer-dead-code branch November 11, 2026 19:10
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.4.0-alpha7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants