Repository navigation
refactor: remove dead code from pdf-viewer - #13391
Merged
Merged
Conversation
This reverts commit 58d3005.
|
web-padawan
marked this pull request as ready for review
November 11, 2026 19:05
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
✅ Nothing to flag — the changes look good.
Risk: 🟢 low — Removal of an unused field from an internal, non-exported helper in an experimental package, with every consumer verified to read only index and ratio and the tests updated in step.
web-padawan
approved these changes
Nov 11, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.4.0-alpha7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Removes dead code from the experimental
<vaadin-pdf-viewer>package.What changed
getVisiblePages()no longer returns the visibleheightof each page. Nothing read it; the current page and render order only useratio. The internalPdfViewerVisiblePagetype is updated to match. This is not public API.Test summary
Working on behalf of Serhii