Skip to content

fix: don't use optional chaining operator - #2078

Merged
web-padawan merged 2 commits into
masterfrom
fix/grid/do-not-use-optional-chaining
Jun 2, 2021
Merged

web-padawan merged 2 commits into
masterfrom
fix/grid/do-not-use-optional-chaining

Conversation

@vursen

@vursen vursen commented Jun 2, 2021 •

Copy link
Copy Markdown
Contributor

Description

As long as the Vaadin Platform targets ES2019 we can't use the optional chaining operator (?.) in the mono-repo.

This PR removes any uses of the optional chaining operator in the mono-repo and fixes the ECMA version for the ESLint parser to align it with the Platform's version (2019).

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen requested a review from tomivirkki June 2, 2021 13:15
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit d324c1e into master Jun 2, 2021
@web-padawan
web-padawan deleted the fix/grid/do-not-use-optional-chaining branch June 2, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants