Skip to content

feat: allow passing specific item type to combo box types - #2088

Merged
sissbruecker merged 2 commits into
masterfrom
feat/combobox_generic_typings
Jun 8, 2021
Merged

sissbruecker merged 2 commits into
masterfrom
feat/combobox_generic_typings

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

Made combo box types generic, similar to how it was done for grid.

Fixes #664

Type of change

  • Feature

@sissbruecker
sissbruecker requested a review from vursen June 8, 2021 06:46

@vursen vursen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't spot anything critical from my point of view, and overall the PR looks like a great improvement 👍

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
sissbruecker merged commit 2a59146 into master Jun 8, 2021
@sissbruecker
sissbruecker deleted the feat/combobox_generic_typings branch June 8, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[combo-box] TypeScript generics to allow declaring item type

2 participants