Skip to content

refactor: use overlapping grid elements to grow/shrink textarea's height - #2143

Merged
fhdhsni merged 3 commits into
masterfrom
refactor/text-area-auto-height
Jun 30, 2021
Merged

fhdhsni merged 3 commits into
masterfrom
refactor/text-area-auto-height

Conversation

@fhdhsni

@fhdhsni fhdhsni commented Jun 22, 2021 •

Copy link
Copy Markdown

related to: #291

The previous solution manually changes the height of the textarea which
imposes some problem with the native focus/scroll behaviour of
browsers.

@fhdhsni
fhdhsni requested a review from tomivirkki June 22, 2021 06:36
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fhdhsni
fhdhsni requested a review from yuriy-fix June 24, 2021 11:19

@yuriy-fix yuriy-fix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

@fhdhsni
fhdhsni merged commit 4ca8293 into master Jun 30, 2021
@fhdhsni
fhdhsni deleted the refactor/text-area-auto-height branch June 30, 2021 11:14
vaadin-bot pushed a commit that referenced this pull request Jul 23, 2021
…ght (#2143)

* refactor: use overlapping grid elements to grow/shrink textarea's height

fixes: #291

* fix visual material's tests

* update form-layout-item-text-area screenshot
vaadin-bot added a commit that referenced this pull request Jul 23, 2021
…ght (#2143) (#2266)

* refactor: use overlapping grid elements to grow/shrink textarea's height

fixes: #291

* fix visual material's tests

* update form-layout-item-text-area screenshot

Co-authored-by: Farhad <farhad@vaadin.com>
sissbruecker added a commit that referenced this pull request Sep 3, 2021
This change prevents the page from scrolling while the text area is measuring its height as part of the auto resize feature, when entering or removing text into the textarea.

Cherry pick of: vaadin/vaadin-text-field#581
Rollback of changes from: #2143
sissbruecker added a commit that referenced this pull request Sep 6, 2021
This change prevents the page from scrolling while the text area is measuring its height as part of the auto resize feature, when entering or removing text into the textarea.

Cherry pick of: vaadin/vaadin-text-field#581
Rollback of changes from: #2143
sissbruecker added a commit that referenced this pull request Sep 6, 2021
This change prevents the page from scrolling while the text area is measuring its height as part of the auto resize feature, when entering or removing text into the textarea.

Cherry pick of: vaadin/vaadin-text-field#581
Rollback of changes from: #2143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants