Skip to content

feat: deprecate render() for menu-bar - #2154

Merged
vursen merged 1 commit into
masterfrom
feat/menu-bar/deprecate-render
Jun 23, 2021
Merged

vursen merged 1 commit into
masterfrom
feat/menu-bar/deprecate-render

Conversation

@vursen

@vursen vursen commented Jun 23, 2021 •

Copy link
Copy Markdown
Contributor

Description

LitElement reserves the render() method to return TemplateResult so we cannot use it for re-rendering vaadin-menu-bar anymore.

This PR deprecates render() for vaadin-menu-bar and supposes it to be removed later.

Part of #73

Type of change

  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@vursen
vursen force-pushed the feat/menu-bar/deprecate-render branch from 328911e to 48c117c Compare June 23, 2021 12:56
@vursen
vursen requested a review from tomivirkki June 23, 2021 12:58
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen added the no-polymer Removing Polymer from Vaadin public APIs label Jun 23, 2021
@vursen
vursen merged commit 96a3d89 into master Jun 23, 2021
@vursen
vursen deleted the feat/menu-bar/deprecate-render branch June 23, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-polymer Removing Polymer from Vaadin public APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants