Skip to content

fix: Correct material theme imports of vaadin-date-picker-light - #2221

Merged
web-padawan merged 1 commit into
vaadin:masterfrom
bramkragten:patch-1
Jul 8, 2021
Merged

web-padawan merged 1 commit into
vaadin:masterfrom
bramkragten:patch-1

Conversation

@bramkragten

Copy link
Copy Markdown
Contributor

Description

The style import of the material theme for vaadin-date-picker-light where pointing at the wrong files.

This PR corrects them.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@bramkragten bramkragten changed the title Correct material theme imports of vaadin-date-picker-light fix: Correct material theme imports of vaadin-date-picker-light Jul 8, 2021
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The change looks good to me.

We will consider adding a visual test for this component to prevent such bugs in future.

@web-padawan

Copy link
Copy Markdown
Member

The visual tests have failed because we don't run them on forks. I'm going to merge this PR regardless.

@web-padawan
web-padawan merged commit 245b619 into vaadin:master Jul 8, 2021
web-padawan pushed a commit that referenced this pull request Jul 11, 2021
) (#2230)

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants