Repository navigation
fix: Correct material theme imports of vaadin-date-picker-light - #2221
Merged
Merged
Conversation
vaadin-date-picker-lightvaadin-date-picker-light
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Jul 8, 2021
web-padawan
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. The change looks good to me.
We will consider adding a visual test for this component to prevent such bugs in future.
Member
|
The visual tests have failed because we don't run them on forks. I'm going to merge this PR regardless. |
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
web-padawan
pushed a commit
that referenced
this pull request
Jul 11, 2021
) (#2230) Co-authored-by: Bram Kragten <mail@bramkragten.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The style import of the
materialtheme forvaadin-date-picker-lightwhere pointing at the wrong files.This PR corrects them.
Fixes # (issue)
Type of change
Checklist
Additional for
Featuretype of change