Repository navigation
feat: add mixins to handle focus and disabled state - #2233
Merged
Merged
Conversation
web-padawan
force-pushed
the
slot-mixins-3
branch
2 times, most recently
from
July 21, 2021 12:38
0517507 to
b86d96d
Compare
web-padawan
force-pushed
the
slot-mixins-3
branch
3 times, most recently
from
July 27, 2021 14:21
d56cc0c to
576d666
Compare
This was referenced Jul 27, 2021
This was referenced Jul 28, 2021
web-padawan
force-pushed
the
slot-mixins-3
branch
from
July 29, 2021 08:50
576d666 to
2006019
Compare
web-padawan
force-pushed
the
slot-mixins-3
branch
from
July 29, 2021 14:26
2006019 to
fda24e0
Compare
web-padawan
marked this pull request as ready for review
July 29, 2021 14:26
vursen
reviewed
Jul 30, 2021
vursen
reviewed
Jul 30, 2021
vursen
reviewed
Jul 30, 2021
vursen
approved these changes
Jul 30, 2021
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This is a third batch of mixins that are needed to implement slotted
inputsupport in field components.The code is mostly the same as in
ControlStateMixin, but there are two important differences:focusElementto be in light DOM so event listeners are updated accordingly,tabindexon the host element, and it is no longer focusable. So we don't handletabindexand expect the user to set it directly on the slotted<input>if needed (although we should not encourage doing this).Fixes #2186
Type of change