Skip to content

fix: allow null and undefined in selected-item-changed event - #2281

Merged
web-padawan merged 4 commits into
masterfrom
fix/type-inconsistency-combobox
Jul 30, 2021
Merged

web-padawan merged 4 commits into
masterfrom
fix/type-inconsistency-combobox

Conversation

@hdamr

@hdamr hdamr commented Jul 28, 2021 •

Copy link
Copy Markdown
Contributor

Description

This PR fixes the inconsistency between selectedItem type in combo box mixin definition and interfaces that we have defined for events.

Fixes #2214

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@hdamr
hdamr requested a review from web-padawan July 28, 2021 11:58
@hdamr
hdamr marked this pull request as ready for review July 28, 2021 12:37
@web-padawan web-padawan changed the title fix type inconsistency for checkbox. fix type inconsistency for combo-box Jul 29, 2021
@web-padawan
web-padawan force-pushed the fix/type-inconsistency-combobox branch from 95ef559 to 910b3c3 Compare July 30, 2021 08:55

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR to simplify by not adding another type alias to align with other components.

@web-padawan web-padawan changed the title fix type inconsistency for combo-box fix: allow null and undefined in selected-item-changed event Jul 30, 2021
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 4e85ae9 into master Jul 30, 2021
@web-padawan
web-padawan deleted the fix/type-inconsistency-combobox branch July 30, 2021 09:10
web-padawan pushed a commit that referenced this pull request Jul 30, 2021
…2285)

Co-authored-by: Hadi Amiri <84700249+hdamr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PiT: Generic in ComboBoxSelectedItemChangedEvent: bad detail object

3 participants