Repository navigation
fix: allow null and undefined in selected-item-changed event - #2281
Merged
Merged
Conversation
hdamr
marked this pull request as ready for review
July 28, 2021 12:37
web-padawan
force-pushed
the
fix/type-inconsistency-combobox
branch
from
July 30, 2021 08:55
95ef559 to
910b3c3
Compare
web-padawan
reviewed
Jul 30, 2021
web-padawan
left a comment
Member
There was a problem hiding this comment.
Updated the PR to simplify by not adding another type alias to align with other components.
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
approved these changes
Jul 30, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
web-padawan
pushed a commit
that referenced
this pull request
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR fixes the inconsistency between
selectedItemtype in combo box mixin definition and interfaces that we have defined for events.Fixes #2214
Type of change
Checklist
Additional for
Featuretype of change